Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Added tests for helpers #1665

Merged
merged 1 commit into from
Dec 17, 2019
Merged

cmd: Added tests for helpers #1665

merged 1 commit into from
Dec 17, 2019

Conversation

akbaruddink
Copy link
Contributor

Related issue

As discussed with @aeneasr on discord, here are some test cases to improve coverage.

Proposed changes

I have added a test case for fatal() helper fn.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@claassistantio
Copy link

claassistantio commented Dec 17, 2019

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Dec 17, 2019

Awesome, thank you!

@aeneasr aeneasr merged commit c9a01e6 into ory:master Dec 17, 2019
eli-zh pushed a commit to eli-zh/hydra that referenced this pull request Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants