Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consent: Fix concurrent write and read on map(#1721) #1722

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

rickwang7712
Copy link
Contributor

Related issue

#1721
@aeneasr

Proposed changes

Fix fatal error: concurrent map iteration and map write by wrapping read part with lock.

Checklist

  • [ x] I have read the contributing guidelines
  • [ x] I have read the security policy
  • [x ] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • [ x] I have added necessary documentation within the code base (if appropriate)
  • [x ] I have documented my changes in the developer guide (if appropriate)

Further comments

@aeneasr I was trying to add tests to catch problem like this, but I met other database's error. And I currently have no time for this... I'm sorry.
Do you think I can open another issue for adding test for it?

    closes ory#1721

Signed-off-by: rickwang <rickwang@synology.com>
@aeneasr aeneasr merged commit 75126de into ory:master Feb 12, 2020
@aeneasr
Copy link
Member

aeneasr commented Feb 12, 2020

Thank you! :)

eli-zh pushed a commit to eli-zh/hydra that referenced this pull request Mar 22, 2020
Closes ory#1721

Signed-off-by: rickwang <rickwang@synology.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants