Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix misused id field #2152

Merged
merged 2 commits into from
Oct 29, 2020
Merged

test: fix misused id field #2152

merged 2 commits into from
Oct 29, 2020

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 29, 2020

Related issue

@zepatrik fyi

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@zepatrik
Copy link
Member

How could tests pass before? I mean this is a type error...

@aeneasr aeneasr merged commit 511e8d2 into master Oct 29, 2020
@aeneasr aeneasr deleted the fix-tests-190 branch October 29, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants