Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix omissions in the description #2173

Closed
wants to merge 1 commit into from
Closed

Conversation

issotina
Copy link
Contributor

@issotina issotina commented Nov 15, 2020

Related issue

Proposed changes

small corrections on the documentation of consent flow but which improves consistency

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2020

CLA assistant check
All committers have signed the CLA.

@vinckr
Copy link
Member

vinckr commented Nov 15, 2020

Thanks so much for your contribution!

Could you please make the same changes in the /docs/docs as well: https://github.com/ory/hydra/blob/master/docs/docs/concepts/consent.mdx

This is the source for versioned docs, so your fix will be in future doc versions too :-).

@aeneasr aeneasr added docs corp/m4 Up for M4 at Ory Corp. labels Nov 16, 2020
@aeneasr aeneasr added this to the v1.9.1 milestone Nov 16, 2020
@aeneasr aeneasr self-assigned this Nov 16, 2020
@aeneasr
Copy link
Member

aeneasr commented Nov 18, 2020

@vinckr could you just quickly do the changes in another PR? Then we could merge right away

@aeneasr aeneasr assigned vinckr and unassigned aeneasr Nov 19, 2020
@issotina
Copy link
Contributor Author

@aeneasr done as you suggested
#2194

@issotina issotina closed this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
corp/m4 Up for M4 at Ory Corp.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants