Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document describe error #2208

Merged
merged 2 commits into from
Dec 1, 2020
Merged

fix: document describe error #2208

merged 2 commits into from
Dec 1, 2020

Conversation

ShiningRush
Copy link
Contributor

Fixed document describe error.

The OAuth 2.0 Client making the request is not allowed to request the scope openid

Should be refresh_token, according here

func canIssueRefreshToken(c *AuthorizeExplicitGrantHandler, request fosite.Requester) bool {
	// Require one of the refresh token scopes, if set.GetGrantTypes
	if len(c.RefreshTokenScopes) > 0 && !request.GetGrantedScopes().HasOneOf(c.RefreshTokenScopes...) {
		return false
	}
	// Do not issue a refresh token to clients that cannot use the refresh token grant type.
	if !request.GetClient().GetGrantTypes().Has("refresh_token") {
		return false
	}
	return true
}

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

Thank you for your contribution!

@aeneasr aeneasr merged commit b59bdf8 into ory:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants