feat: encode flow in cookie + URL params #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* JOIN flows with client
* JOIN flows with client
…' into hperl/bench-hydra-auth-code-flow # Conflicts: # internal/testhelpers/oauth2.go # oauth2/oauth2_auth_code_bench_test.go
…ra into hperl/bench-hydra-auth-code-flow
…ra into hperl/bench-hydra-auth-code-flow
aeneasr
reviewed
Jun 7, 2023
persistence/sql/migratest/fixtures/hydra_oauth2_flow/challenge-0005.json
Outdated
Show resolved
Hide resolved
persistence/sql/migrations/20230606112801000001_remove_flow_indices.up.sql
Outdated
Show resolved
Hide resolved
persistence/sql/migrations/20230606112801000001_remove_flow_indices.up.sql
Outdated
Show resolved
Hide resolved
aeneasr
reviewed
Jun 9, 2023
persistence/sql/migrations/20230606112801000001_remove_flow_indices.mysql.up.sql
Outdated
Show resolved
Hide resolved
|
@hperl two failing tests atm |
|
Since we'll squash merge this anyways, I'll merge master into this branch. |
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 14, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 14, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 14, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 14, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 15, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 15, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 15, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 16, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 16, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 16, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 16, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
hperl
added a commit
to ory/kratos
that referenced
this pull request
Jun 16, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
aeneasr
pushed a commit
to ory/kratos
that referenced
this pull request
Jun 19, 2023
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the performance of authorization code grant flows by minimizing the number of database queries. We acheive this by storing the flow in an AEAD-encoded cookie and AEAD-encoded request parameters for the authentication and consent screens.
Breaking changes