Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate image to distroless #3539

Merged
merged 17 commits into from
Jun 22, 2023
Merged

Conversation

Demonsthere
Copy link
Contributor

@Demonsthere Demonsthere commented Jun 6, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

  • Downgrade alpine image to 3.17 due to failing package upgrade
  • Migrate to debian builder and distroless:base image to avoid CVE issues in base containers. We cannot migrate to static as hydra is build with dynamic linking.

@Demonsthere Demonsthere marked this pull request as ready for review June 6, 2023 13:43
@Demonsthere Demonsthere requested a review from aeneasr as a code owner June 6, 2023 13:43
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #3539 (10e3c7d) into master (4b4c033) will not change coverage.
The diff coverage is n/a.

❗ Current head 10e3c7d differs from pull request most recent head fd77bf9. Consider uploading reports for the commit fd77bf9 to get more accurate results

@@           Coverage Diff           @@
##           master    #3539   +/-   ##
=======================================
  Coverage   76.62%   76.62%           
=======================================
  Files         129      129           
  Lines        9630     9630           
=======================================
  Hits         7379     7379           
  Misses       1749     1749           
  Partials      502      502           

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works with sqlite 👍

.docker/Dockerfile-build Outdated Show resolved Hide resolved
@Demonsthere Demonsthere marked this pull request as draft June 6, 2023 19:01
@Demonsthere Demonsthere changed the title feat: migrate image to distroless feat: migrate image to distroless [WIP] Jun 6, 2023
@Demonsthere Demonsthere marked this pull request as ready for review June 7, 2023 08:17
@Demonsthere Demonsthere changed the title feat: migrate image to distroless [WIP] feat: migrate image to distroless Jun 7, 2023
aeneasr
aeneasr previously requested changes Jun 7, 2023
.docker/Dockerfile-build Outdated Show resolved Hide resolved
zepatrik
zepatrik previously approved these changes Jun 13, 2023
@aeneasr
Copy link
Member

aeneasr commented Jun 14, 2023

This needs changes in ory/xgoreleaser first

@zepatrik zepatrik merged commit c1e1a56 into ory:master Jun 22, 2023
@Demonsthere Demonsthere deleted the feat/distroless branch June 22, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants