Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve persistence logic #3756

Merged
merged 3 commits into from
Apr 5, 2024
Merged

feat: improve persistence logic #3756

merged 3 commits into from
Apr 5, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Apr 5, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.42%. Comparing base (4f786c6) to head (9f6a07b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3756      +/-   ##
==========================================
+ Coverage   76.31%   76.42%   +0.11%     
==========================================
  Files         134      135       +1     
  Lines       10214    10283      +69     
==========================================
+ Hits         7795     7859      +64     
- Misses       1902     1905       +3     
- Partials      517      519       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr marked this pull request as ready for review April 5, 2024 14:03
@aeneasr aeneasr requested a review from hperl as a code owner April 5, 2024 14:03
@aeneasr aeneasr merged commit 50301e0 into master Apr 5, 2024
32 checks passed
@aeneasr aeneasr deleted the add-expiry branch April 5, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant