Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change comment on revokeOAuth2LoginSessions #3853

Merged

Conversation

sakai-303
Copy link
Contributor

Related issue(s)

This is not an issue, but the related discussions can be found below.
https://github.com/orgs/ory/discussions/118

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link
Contributor

@alnr alnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? I don't think it is. Need to look at this in detail.

@aeneasr
Copy link
Member

aeneasr commented Oct 10, 2024

This is correct, due to a cascade delete of request_id, see also: https://github.com/orgs/ory/discussions/118

@aeneasr aeneasr merged commit 6d829dd into ory:master Oct 10, 2024
29 checks passed
@aeneasr
Copy link
Member

aeneasr commented Oct 10, 2024

CONSTRAINT hydra_oauth2_refresh_challenge_id_fk FOREIGN KEY (challenge_id) REFERENCES public.hydra_oauth2_flow(consent_challenge_id) ON DELETE CASCADE,

@alnr
Copy link
Contributor

alnr commented Oct 10, 2024

This PR is incorrect. Revoking a login session does not revoke access tokens and also does not revoke consent!

@alnr
Copy link
Contributor

alnr commented Oct 10, 2024

It also does not revoke refresh tokens.

@alnr
Copy link
Contributor

alnr commented Oct 10, 2024

Added comment in https://github.com/orgs/ory/discussions/118

@alnr
Copy link
Contributor

alnr commented Oct 10, 2024

Revert #3858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants