-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change comment on revokeOAuth2LoginSessions #3853
fix: change comment on revokeOAuth2LoginSessions #3853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? I don't think it is. Need to look at this in detail.
This is correct, due to a cascade delete of request_id, see also: https://github.com/orgs/ory/discussions/118 |
|
This PR is incorrect. Revoking a login session does not revoke access tokens and also does not revoke consent! |
It also does not revoke refresh tokens. |
Added comment in https://github.com/orgs/ory/discussions/118 |
Revert #3858 |
Related issue(s)
This is not an issue, but the related discussions can be found below.
https://github.com/orgs/ory/discussions/118
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments