Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retry crdb serializable errors #3895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Nov 25, 2024

Correctly retries serializability errors in CockroachDB.

Related issue(s)

See https://github.com/ory-corp/cloud/issues/7311

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link
Contributor

@alnr alnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

difficult to test programatically I guess

@aeneasr
Copy link
Member Author

aeneasr commented Nov 25, 2024

We do have tests in network for this so if it passes there it's fine here too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants