Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kratos hydra integration #198

Merged
merged 6 commits into from
Oct 5, 2022

Conversation

grantzvolsky
Copy link
Contributor

This branch is based on the fix-new-sdk branch which was ahead of master.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

Further comments

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit-pick, otherwise LGTM :)

src/pkg/ui.ts Outdated Show resolved Hide resolved
@aeneasr aeneasr merged commit a390516 into ory:master Oct 5, 2022
grantzvolsky added a commit to grantzvolsky/kratos-selfservice-ui-node that referenced this pull request Oct 5, 2022
@jpollard-cs
Copy link

🥳

aeneasr pushed a commit that referenced this pull request Oct 6, 2022
aeneasr added a commit to ory/kratos that referenced this pull request Oct 26, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants