fix: missing issuer regression in OIDC (#3220)

Closes #3182 Closes #3040
ory · Apr 7, 2023 · 52f0740 · 52f0740
1 parent 0ba0bd6
commit 52f0740
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/selfservice/strategy/oidc/provider_auth0.go b/selfservice/strategy/oidc/provider_auth0.go
@@ -11,6 +11,8 @@ import (
 	"path"
 	"time"
 
+	"github.com/ory/x/stringsx"
+
 	"github.com/tidwall/sjson"
 
 	"github.com/hashicorp/go-retryablehttp"
@@ -116,6 +118,7 @@ func (g *ProviderAuth0) Claims(ctx context.Context, exchange *oauth2.Token, quer
 		return nil, errors.WithStack(herodot.ErrInternalServerError.WithReasonf("%s", err))
 	}
 
+	claims.Issuer = stringsx.Coalesce(claims.Issuer, g.config.IssuerURL)
 	return &claims, nil
 }
 

diff --git a/selfservice/strategy/oidc/provider_gitlab.go b/selfservice/strategy/oidc/provider_gitlab.go
@@ -9,6 +9,8 @@ import (
 	"net/url"
 	"path"
 
+	"github.com/ory/x/stringsx"
+
 	"github.com/hashicorp/go-retryablehttp"
 
 	"github.com/ory/x/httpx"
@@ -101,6 +103,7 @@ func (g *ProviderGitLab) Claims(ctx context.Context, exchange *oauth2.Token, que
 		return nil, errors.WithStack(herodot.ErrInternalServerError.WithReasonf("%s", err))
 	}
 
+	claims.Issuer = stringsx.Coalesce(claims.Issuer, g.config.IssuerURL)
 	return &claims, nil
 }
 

diff --git a/selfservice/strategy/oidc/provider_netid.go b/selfservice/strategy/oidc/provider_netid.go
@@ -114,7 +114,6 @@ func (n *ProviderNetID) Claims(ctx context.Context, exchange *oauth2.Token, _ ur
 	if err := json.NewDecoder(resp.Body).Decode(&userinfo); err != nil {
 		return nil, errors.WithStack(herodot.ErrInternalServerError.WithReasonf("%s", err))
 	}
-
 	userinfo.Issuer = claims.Issuer
 	userinfo.Subject = claims.Subject
 	return &userinfo, nil