Skip to content

Commit

Permalink
fix: IdentityCreated event (#3314)
Browse files Browse the repository at this point in the history
  • Loading branch information
aeneasr committed Jun 13, 2023
1 parent d3f3be3 commit 78e31cb
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions identity/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,12 @@ func (m *Manager) Create(ctx context.Context, i *Identity, opts ...ManagerOption
return err
}

if err := m.r.PrivilegedIdentityPool().CreateIdentity(ctx, i); err != nil {
return err
}

trace.SpanFromContext(ctx).AddEvent(events.NewIdentityCreated(ctx, i.ID))
return m.r.PrivilegedIdentityPool().CreateIdentity(ctx, i)
return nil
}

func (m *Manager) CreateIdentities(ctx context.Context, identities []*Identity, opts ...ManagerOption) (err error) {
Expand All @@ -109,8 +113,15 @@ func (m *Manager) CreateIdentities(ctx context.Context, identities []*Identity,
}
}

err = m.r.PrivilegedIdentityPool().CreateIdentities(ctx, identities...)
return err
if err := m.r.PrivilegedIdentityPool().CreateIdentities(ctx, identities...); err != nil {
return err
}

for _, i := range identities {
trace.SpanFromContext(ctx).AddEvent(events.NewIdentityCreated(ctx, i.ID))
}

return nil
}

func (m *Manager) requiresPrivilegedAccess(ctx context.Context, original, updated *Identity, o *ManagerOptions) (err error) {
Expand Down

0 comments on commit 78e31cb

Please sign in to comment.