test: remove duplicate t.Parallel

cmd/daemon/serve.go

@@ -113,10 +113,9 @@ func ServePublic(r driver.Registry, cmd *cobra.Command, _ []string, slOpts *serv
 	r.PrometheusManager().RegisterRouter(router.Router)
 
 	var handler http.Handler = n
-	options, enabled := r.Config().CORS(ctx, "public")
-	if enabled {
-		handler = cors.New(options).Handler(handler)
-	}
+	options, _ := r.Config().CORS(ctx, "public")
+	// we need to always load the CORS middleware to allow hot-enabling CORS
+	handler = cors.New(options).Handler(handler)
 
 	certs := c.GetTLSCertificatesForPublic(ctx)
 

driver/config/config.go

@@ -480,6 +480,11 @@ func (p *Config) cors(ctx context.Context, prefix string) (cors.Options, bool) {
 		AllowCredentials: true,
 	})
 	opts.AllowOriginRequestFunc = func(r *http.Request, origin string) bool {
+		// if cors is not enabled, return false
+		// this enables hot-reloading on every request
+		if !p.GetProvider(r.Context()).Bool(prefix + ".cors.enabled") {
+			return false
+		}
 		// load the origins from the config on every request to allow hot-reloading
 		allowedOrigins := p.GetProvider(r.Context()).Strings(prefix + ".cors.allowed_origins")
 		return corsx.CheckOrigin(allowedOrigins, origin)

driver/config/config_test.go

@@ -49,7 +49,6 @@ func TestViperProvider(t *testing.T) {
 	t.Parallel()
 	ctx, cancel := context.WithCancel(context.Background())
 	t.Cleanup(cancel)
-	t.Parallel()
 
 	t.Run("suite=loaders", func(t *testing.T) {
 		p := config.MustNew(t, logrusx.New("", ""), os.Stderr,
@@ -810,7 +809,6 @@ func newTestConfig(t *testing.T) (_ *config.Config, _ *test.Hook, exited *bool)
 func TestLoadingTLSConfig(t *testing.T) {
 	t.Parallel()
 	ctx := context.Background()
-	t.Parallel()
 
 	certPath, keyPath, certBase64, keyBase64 := testhelpers.GenerateTLSCertificateFilesForTests(t)