Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version schema generation as the path of the config schema changed #1101

Closed
zepatrik opened this issue Feb 28, 2021 · 0 comments · Fixed by #1359
Closed

Fix version schema generation as the path of the config schema changed #1101

zepatrik opened this issue Feb 28, 2021 · 0 comments · Fixed by #1359
Assignees
@zepatrik
Labels
blocking Blocks milestones or other issues or pulls. upstream Issue is caused by an upstream dependency.

Comments

@zepatrik
Copy link
Member

Describe the bug

The current version schema is generated with the assumption that the config schema is /.schema/config.schema.json. We have to fix that before the next release to not break it.
@zepatrik zepatrik added blocking Blocks milestones or other issues or pulls. upstream Issue is caused by an upstream dependency. ci labels Feb 28, 2021
@zepatrik zepatrik self-assigned this Feb 28, 2021
@zepatrik zepatrik mentioned this issue May 18, 2021
Merged
aeneasr pushed a commit that referenced this issue May 18, 2021
@zepatrik
fix: version schema (#1359)
8c4bac7 
Closes #1331
Closes #1101

This fixes the config schema paths in the version.schema.json to reflect the new path since we use go embed.

See also ory/hydra#2427

The CI was also updated to include the new schema path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepatrik zepatrik

Labels
blocking Blocks milestones or other issues or pulls. upstream Issue is caused by an upstream dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: version schema ory/kratos
1 participant
@zepatrik