Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC Credentials do not allow multiple connections #114

Closed
aeneasr opened this issue Nov 9, 2019 · 0 comments · Fixed by #191
Closed

OIDC Credentials do not allow multiple connections #114

aeneasr opened this issue Nov 9, 2019 · 0 comments · Fixed by #191
Assignees
Labels
bug Something is not working. package/selfservice/oidc Affects the OpenID Connect Self Service Strategy

Comments

@aeneasr
Copy link
Member

aeneasr commented Nov 9, 2019

Is your feature request related to a problem? Please describe.

At the moment,oidc.CredentialsConfig looks like this

type CredentialsConfig struct {
	Subject  string `json:"subject"`
	Provider string `json:"provider"`
}

and the credentials type is created as such:

	i.SetCredentials(s.ID(), identity.Credentials{
		ID:          s.ID(),
		Identifiers: []string{uid(provider.Config().ID, claims.Subject)},
		Config:      b.Bytes(),
	})

The problem with this is that while we might support multiple identifiers for the "oidc" credentials type, this would not reflect in the config portion at it is not an array.

Describe the solution you'd like

Instead, an array of providers should be possible in the config to support this use case. Additionally, we might add further things such as "AccessToken" and "RefreshToken" in there.

Describe alternatives you've considered

None.

Additional context

This is already documented as an array.

@aeneasr aeneasr added bug Something is not working. package/selfservice/oidc Affects the OpenID Connect Self Service Strategy labels Nov 9, 2019
@aeneasr aeneasr added this to the v0.0.1 milestone Nov 9, 2019
@aeneasr aeneasr self-assigned this Nov 9, 2019
aeneasr added a commit that referenced this issue Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working. package/selfservice/oidc Affects the OpenID Connect Self Service Strategy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant