Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallowing logoutURL does not remove the session cookie. #1584

Closed
atstoyanov opened this issue Jul 23, 2021 · 0 comments · Fixed by #1587
Closed

Fallowing logoutURL does not remove the session cookie. #1584

atstoyanov opened this issue Jul 23, 2021 · 0 comments · Fixed by #1587

Comments

@atstoyanov
Copy link

Describe the bug

Fallowing the logoutUrl generated by kratosClient.createSelfServiceLogoutFlowUrlForBrowsers() does not remove the ory_kratos_session cookie.

Reproducing the bug

Steps to reproduce the behavior:

  1. Fallow this guide to bring up the environment
    https://www.ory.sh/kratos/docs/guides/zero-trust-iap-proxy-identity-access-proxy/#running-ory-kratos-and-the-ory-oathkeeper-identity-and-access-proxy

  2. Navigate to http://127.0.0.1:4455

  3. Register anuser

  4. Logout

  5. Check the browser cookies. The ory_kratos_session cookie is still present.

Server logs

Server configuration

Expected behavior

In the previous version (v0.6.1) the cookie was automatically removed.

Environment

  • Version: v0.7.0 and v0.7.1
  • Environment: Docker

Additional context
Discussion about the issue and how affects our use case:
#1582
aeneasr added a commit that referenced this issue Jul 23, 2021
@aeneasr
fix: remove session cookie on logout
538d714 
Before, the logout endpoint would invalidate the session cookie, but not remove it. This was a regression introduced in 0.7.0. This patch resolves that issue.

Closes #1584
@aeneasr aeneasr mentioned this issue Jul 23, 2021
Merged
6 tasks
aeneasr added a commit that referenced this issue Jul 23, 2021
@aeneasr
fix: remove session cookie on logout (#1587)
cdb30bb 
Before, the logout endpoint would invalidate the session cookie, but not remove it. This was a regression introduced in 0.7.0. This patch resolves that issue.

Closes #1584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove session cookie on logout ory/kratos
1 participant
@atstoyanov