-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: all admin endpoints are now exposed under /admin/
on the …
#2292
Conversation
d9b14cb
to
4ffc910
Compare
Codecov Report
@@ Coverage Diff @@
## master #2292 +/- ##
=========================================
Coverage ? 76.59%
=========================================
Files ? 318
Lines ? 17134
Branches ? 0
=========================================
Hits ? 13124
Misses ? 3080
Partials ? 930
Continue to review full report at Codecov.
|
5b383a6
to
0e64ad8
Compare
…admin port BREAKING CHANGE: All endpoints at the Admin API are now exposed at `/admin/`. For example, endpoint `https://kratos:4434/identities` is now exposed at `https://kratos:4434/admin/identities`. This change makes it easier to configure reverse proxies and API Gateways. Additionally, it introduces 1:1 compatibility between Ory Cloud's APIs and self-hosted Ory Kratos. Please note that nothing has changed in terms of the port. To make the migration less painful, we have set up redirects from the old endpoints to the new `/admin` endpoints, so your APIs, SDKs, and clients should continue working as they were working before. This change is marked as a breaking change as it touches many endpoints and might be confusing when encountering the redirect for the first time.
Windows users were broken since #2292, as routes were registered with backslashes.
Windows users were broken since ory#2292, as routes were registered with backslashes.
…admin port
BREAKING CHANGE: All endpoints at the Admin API are now exposed at
/admin/
. For example, endpointhttps://kratos:4434/identities
is now exposed athttps://kratos:4434/admin/identities
. This change makes it easier to configure reverse proxies and API Gateways. Additionally, it introduces 1:1 compatibility between Ory Cloud's APIs and self-hosted Ory Kratos. Please note that nothing has changed in terms of the port. To make the migration less painful, we have set up redirects from the old endpoints to the new/admin
endpoints, so your APIs, SDKs, and clients should continue working as they were working before. This change is marked as a breaking change as it touches many endpoints and might be confusing when encountering the redirect for the first time.Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments