Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use path instead of filepath to join http route paths #2387

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

zepatrik
Copy link
Member

Windows users were broken since #2292, as routes were registered with backslashes.

See report in https://ory-community.slack.com/archives/C012RJ2MQ1H/p1649677432507569?thread_ts=1649658406.402509&cid=C012RJ2MQ1H

Windows users were broken since #2292, as routes were registered with backslashes.
@zepatrik zepatrik requested a review from aeneasr as a code owner April 11, 2022 12:13
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #2387 (b5b4ba7) into master (9519978) will decrease coverage by 0.08%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master    #2387      +/-   ##
==========================================
- Coverage   76.60%   76.51%   -0.09%     
==========================================
  Files         315      315              
  Lines       17320    17320              
==========================================
- Hits        13268    13253      -15     
- Misses       3119     3130      +11     
- Partials      933      937       +4     
Impacted Files Coverage Δ
x/router.go 68.18% <60.00%> (ø)
x/redir.go 100.00% <100.00%> (ø)
courier/smtp.go 60.57% <0.00%> (-10.58%) ⬇️
courier/courier_dispatcher.go 52.94% <0.00%> (-3.93%) ⬇️
session/test/persistence.go 98.61% <0.00%> (-1.39%) ⬇️
persistence/sql/persister_courier.go 88.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e505513...b5b4ba7. Read the comment docs.

@zepatrik zepatrik merged commit b5b4ba7 into master Apr 11, 2022
@zepatrik zepatrik deleted the fix/path-filepath-confusion branch April 11, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants