Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update an identity's credentials when update an identity #2334

Closed
3 of 6 tasks
TheFu527 opened this issue Mar 23, 2022 · 4 comments · Fixed by #2423
Closed
3 of 6 tasks

Update an identity's credentials when update an identity #2334

TheFu527 opened this issue Mar 23, 2022 · 4 comments · Fixed by #2423
Labels
feat New feature or request.

Comments

@TheFu527
Copy link

Preflight checklist

Describe your problem

Currently, in v0.9.0, creating a password when creating identity is supported (POST /admin/identities).

However, the corresponding update does not implement the relevant features (PUT /admin/identities/{id}).

Describe your ideal solution

Make it possible to update an identity's credentials using the Update an Identity API (PUT /admin/identities/{id}).

Workarounds or alternatives

At present, I implement this feature by creating my own API and directly modifying the related tables in MySQL.

Version

v0.9.0

Additional Context

No response

@TheFu527 TheFu527 added the feat New feature or request. label Mar 23, 2022
@vinckr
Copy link
Member

vinckr commented Mar 23, 2022

It does seem sensible, but can you share a bit of details on your use case, so we can better understand why this is needed.

Usually end-users would update credentials in a self-service settings flow. And the (POST /admin/identities) works when creating identities.

This feature would be for a case where the end-user already has an identity in Kratos created and then you need to change the password without end-user interaction, is that correct?

@TheFu527
Copy link
Author

This feature would be for a case where the end-user already has an identity in Kratos created and then you need to change the password without end-user interaction, is that correct?

Yes, it is. We need the administrator to directly modify the password of any user without end-user interaction.

@aeneasr
Copy link
Member

aeneasr commented Apr 11, 2022

That makes sense :) For anyone looking, I think this should be realtively easy to implement. Just port the functionality from POST to PUT!

@tsirkin
Copy link
Contributor

tsirkin commented Apr 25, 2022

Hi
Submitted a PR to fix this.
I have problems running the tests (unrelated to the PR), please review/let me know what is the problem with tests/how to run them.

peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this issue Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants