Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile uses quickstart binary in quickstart target #2488

Closed
3 of 6 tasks
halms opened this issue May 23, 2022 · 0 comments · Fixed by #2490
Closed
3 of 6 tasks

Makefile uses quickstart binary in quickstart target #2488

halms opened this issue May 23, 2022 · 0 comments · Fixed by #2490
Assignees
Labels
bug Something is not working.

Comments

@halms
Copy link

halms commented May 23, 2022

Preflight checklist

Describe the bug

The Makefile uses a quickstart binary in the quickstart and quickstart-dev targets.
This change was introduced in #2206.

It looks to me, as if the change was initially planned to include a quickstart binary in the EXECUTABLES line, as is shown in the review to #2206.

I don't know if this is just a plain mistake or if some software package actually includes a quickstart binary that works as a replacement for docker-compose. I could not find anything googling for a quickstart binary (but as this is a very generic term, it is actually hard to find something specific).

My suggestion would be, to change this back to using Compose.
Ideally this would be the new Compose v2, which is called via docker compose and not docker-compose anymore.

Also, the docker build command in the quickstart-dev target is different from the line in the docker target.
I would suggest to just have the quickstart-dev target depend on the docker target.

I am happy to create a PR changing the Makefile but would like to clarify this here before.

Reproducing the bug

  • Run make quickstart in kratos directory
  • Command fails with
    /bin/bash: line 1: quickstart: command not found

Relevant log output

No response

Relevant configuration

No response

Version

Current master, but bug present since v0.9.0

On which operating system are you observing this issue?

No response

In which environment are you deploying?

No response

Additional Context

No response

@halms halms added the bug Something is not working. label May 23, 2022
@aeneasr aeneasr self-assigned this May 25, 2022
aeneasr added a commit that referenced this issue May 25, 2022
aeneasr added a commit that referenced this issue May 25, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this issue Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants