Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add after_verification_return_to to sdk and api docs #3097

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

Benehiko
Copy link
Contributor

Related issue(s)

Fixes: #3096

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

//
// required: false
// in: query
AfterVerificationReturnTo string `json:"after_verification_return_to"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should also be considered with the native flow? since the user could technically be completing the verification flow through a browser or on a different device?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is perfect for now!

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #3097 (f3fa492) into master (e916a74) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3097      +/-   ##
==========================================
+ Coverage   77.33%   77.35%   +0.02%     
==========================================
  Files         315      315              
  Lines       19816    19816              
==========================================
+ Hits        15325    15329       +4     
+ Misses       3300     3297       -3     
+ Partials     1191     1190       -1     
Impacted Files Coverage Δ
selfservice/flow/registration/handler.go 79.37% <ø> (ø)
session/test/persistence.go 100.00% <0.00%> (+0.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit c70704c into master Feb 13, 2023
@aeneasr aeneasr deleted the fix-registration-param branch February 13, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after_verification_return_to is not in SDK and API documentation for Registration flow
2 participants