Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add after_verification_return_to to sdk and api docs #3097

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix: add after_verification_return_to to sdk and api docs #3097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions internal/client-go/api_frontend.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 12 additions & 4 deletions internal/httpclient/api_frontend.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions selfservice/flow/registration/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,16 @@ type createBrowserRegistrationFlow struct {
// required: false
// in: query
LoginChallenge string `json:"login_challenge"`

// The URL to return the browser to after the verification flow was completed.
//
// After the registration flow is completed, the user will be sent a verification email.
// Upon completing the verification flow, this URL will be used to override the default
// `selfservice.flows.verification.after.default_redirect_to` value.
//
// required: false
// in: query
AfterVerificationReturnTo string `json:"after_verification_return_to"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should also be considered with the native flow? since the user could technically be completing the verification flow through a browser or on a different device?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is perfect for now!

}

// swagger:route GET /self-service/registration/browser frontend createBrowserRegistrationFlow
Expand Down
8 changes: 8 additions & 0 deletions spec/api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5458,6 +5458,14 @@
"schema": {
"type": "string"
}
},
{
"description": "The URL to return the browser to after the verification flow was completed.\n\nAfter the registration flow is completed, the user will be sent a verification email.\nUpon completing the verification flow, this URL will be used to override the default\n`selfservice.flows.verification.after.default_redirect_to` value.",
"in": "query",
"name": "after_verification_return_to",
"schema": {
"type": "string"
}
}
],
"responses": {
Expand Down
6 changes: 6 additions & 0 deletions spec/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2061,6 +2061,12 @@
"description": "Ory OAuth 2.0 Login Challenge.\n\nIf set will cooperate with Ory OAuth2 and OpenID to act as an OAuth2 server / OpenID Provider.\n\nThe value for this parameter comes from `login_challenge` URL Query parameter sent to your\napplication (e.g. `/registration?login_challenge=abcde`).\n\nThis feature is compatible with Ory Hydra when not running on the Ory Network.",
"name": "login_challenge",
"in": "query"
},
{
"type": "string",
"description": "The URL to return the browser to after the verification flow was completed.\n\nAfter the registration flow is completed, the user will be sent a verification email.\nUpon completing the verification flow, this URL will be used to override the default\n`selfservice.flows.verification.after.default_redirect_to` value.",
"name": "after_verification_return_to",
"in": "query"
}
],
"responses": {
Expand Down