-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document identity hooks #31
Milestone
Comments
Thank you for your contribution, we value it! However, this issue has been marked as stale because it has not had recent activity, or because it does not comply with our contribution guidelines. If it is the latter, please follow the instructions from the comment above to comply with our guidelines. It will be closed if no further activity occurs. Thank you for your contributions. |
aeneasr
added a commit
that referenced
this issue
Apr 15, 2020
This patch focuses on refactoring how self-service flows terminate and changes how hooks behave and when they are executed. Before this patch, it was not clear whether hooks run before or after an identity is persisted. This caused problems with multiple writes on the HTTP ResponseWriter and other bugs. This patch removes hooks from after login, registration, and profile flows. Per default, these flows now respond with an appropriate payload ( redirect for browsers, JSON for API clients) and deprecate the `redirect` hook. This patch includes documentation which explains how these hooks work now. Additionally, the documentation was updated. Especially the sections about hooks have been refactored. The login and user registration docs have been updated to reflect the latest changes as well. Also, some other minor, cosmetic, changes to the documentation have been made. Closes #348 See #347 See #179 Closes #51 Closes #50 Closes #31 BREAKING CHANGE: Please remove the `redirect` hook from both login, registration, and settings after configuration. Please remove the `session` hook from your login after configuration. Hooks have moved down a level and are now configured at `selfservice.<login|registration|settings>.<after|before>.hooks` instead of `selfservice.<login|registration|settings>.<after|before>.hooks`. Hooks are now identified by `hook:` instead of `job:`. Please rename those sections accordingly.
aeneasr
added a commit
that referenced
this issue
Apr 15, 2020
This patch focuses on refactoring how self-service flows terminate and changes how hooks behave and when they are executed. Before this patch, it was not clear whether hooks run before or after an identity is persisted. This caused problems with multiple writes on the HTTP ResponseWriter and other bugs. This patch removes hooks from after login, registration, and profile flows. Per default, these flows now respond with an appropriate payload ( redirect for browsers, JSON for API clients) and deprecate the `redirect` hook. This patch includes documentation which explains how these hooks work now. Additionally, the documentation was updated. Especially the sections about hooks have been refactored. The login and user registration docs have been updated to reflect the latest changes as well. Also, some other minor, cosmetic, changes to the documentation have been made. Closes #348 See #347 See #179 Closes #51 Closes #50 Closes #31 BREAKING CHANGE: Please remove the `redirect` hook from both login, registration, and settings after configuration. Please remove the `session` hook from your login after configuration. Hooks have moved down a level and are now configured at `selfservice.<login|registration|settings>.<after|before>.hooks` instead of `selfservice.<login|registration|settings>.<after|before>.hooks`. Hooks are now identified by `hook:` instead of `job:`. Please rename those sections accordingly.
aeneasr
added a commit
that referenced
this issue
Apr 15, 2020
This patch focuses on refactoring how self-service flows terminate and changes how hooks behave and when they are executed. Before this patch, it was not clear whether hooks run before or after an identity is persisted. This caused problems with multiple writes on the HTTP ResponseWriter and other bugs. This patch removes hooks from after login, registration, and profile flows. Per default, these flows now respond with an appropriate payload ( redirect for browsers, JSON for API clients) and deprecate the `redirect` hook. This patch includes documentation which explains how these hooks work now. Additionally, the documentation was updated. Especially the sections about hooks have been refactored. The login and user registration docs have been updated to reflect the latest changes as well. Also, some other minor, cosmetic, changes to the documentation have been made. Closes #348 See #347 See #179 Closes #51 Closes #50 Closes #31 BREAKING CHANGE: Please remove the `redirect` hook from both login, registration, and settings after configuration. Please remove the `session` hook from your login after configuration. Hooks have moved down a level and are now configured at `selfservice.<login|registration|settings>.<after|before>.hooks` instead of `selfservice.<login|registration|settings>.<after|before>.hooks`. Hooks are now identified by `hook:` instead of `job:`. Please rename those sections accordingly.
aeneasr
added a commit
that referenced
this issue
Apr 15, 2020
This patch focuses on refactoring how self-service flows terminate and changes how hooks behave and when they are executed. Before this patch, it was not clear whether hooks run before or after an identity is persisted. This caused problems with multiple writes on the HTTP ResponseWriter and other bugs. This patch removes hooks from after login, registration, and profile flows. Per default, these flows now respond with an appropriate payload ( redirect for browsers, JSON for API clients) and deprecate the `redirect` hook. This patch includes documentation which explains how these hooks work now. Additionally, the documentation was updated. Especially the sections about hooks have been refactored. The login and user registration docs have been updated to reflect the latest changes as well. Also, some other minor, cosmetic, changes to the documentation have been made. Closes #348 See #347 See #179 Closes #51 Closes #50 Closes #31 BREAKING CHANGE: Please remove the `redirect` hook from both login, registration, and settings after configuration. Please remove the `session` hook from your login after configuration. Hooks have moved down a level and are now configured at `selfservice.<login|registration|settings>.<after|before>.hooks` instead of `selfservice.<login|registration|settings>.<after|before>.hooks`. Hooks are now identified by `hook:` instead of `job:`. Please rename those sections accordingly.
aeneasr
added a commit
that referenced
this issue
Apr 15, 2020
This patch focuses on refactoring how self-service flows terminate and changes how hooks behave and when they are executed. Before this patch, it was not clear whether hooks run before or after an identity is persisted. This caused problems with multiple writes on the HTTP ResponseWriter and other bugs. This patch removes certain hooks from after login, registration, and profile flows. Per default, these flows now respond with an appropriate payload ( redirect for browsers, JSON for API clients) and deprecate the `redirect` hook. This patch includes documentation which explains how these hooks work now. Additionally, the documentation was updated. Especially the sections about hooks have been refactored. The login and user registration docs have been updated to reflect the latest changes as well. Also, some other minor, cosmetic, changes to the documentation have been made. Closes #348 See #347 See #179 Closes #51 Closes #50 Closes #31 BREAKING CHANGE: Please remove the `redirect` hook from both login, registration, and settings after configuration. Please remove the `session` hook from your login after configuration. Hooks have moved down a level and are now configured at `selfservice.<login|registration|settings>.<after|before>.hooks` instead of `selfservice.<login|registration|settings>.<after|before>.hooks`. Hooks are now identified by `hook:` instead of `job:`. Please rename those sections accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: