Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing issuer regression in OIDC #3220

Merged
merged 2 commits into from
Apr 7, 2023
Merged

fix: missing issuer regression in OIDC #3220

merged 2 commits into from
Apr 7, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Apr 7, 2023

Closes #3182
Closes #3040

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner April 7, 2023 11:36
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #3220 (80e3642) into master (f088ccd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 80e3642 differs from pull request most recent head f42d65e. Consider uploading reports for the commit f42d65e to get more accurate results

@@            Coverage Diff             @@
##           master    #3220      +/-   ##
==========================================
+ Coverage   77.89%   77.93%   +0.03%     
==========================================
  Files         319      319              
  Lines       20429    20431       +2     
==========================================
+ Hits        15914    15922       +8     
+ Misses       3315     3311       -4     
+ Partials     1200     1198       -2     
Impacted Files Coverage Δ
selfservice/strategy/oidc/provider_netid.go 75.00% <ø> (ø)
selfservice/strategy/oidc/provider_auth0.go 72.30% <100.00%> (+0.43%) ⬆️
selfservice/strategy/oidc/provider_gitlab.go 81.81% <100.00%> (+0.33%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 52f0740 into master Apr 7, 2023
@aeneasr aeneasr deleted the fix-issuer-issues branch April 7, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Sign in with Auth0 'issuer not set in claims.' Gitlab OIDC registration does not work anymore
1 participant