Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IdentityCreated event #3314

Merged
merged 1 commit into from
Jun 13, 2023
Merged

fix: IdentityCreated event #3314

merged 1 commit into from
Jun 13, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 13, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner June 13, 2023 09:40
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #3314 (37e6537) into master (d3f3be3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 37e6537 differs from pull request most recent head 7cac1c0. Consider uploading reports for the commit 7cac1c0 to get more accurate results

@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
- Coverage   78.11%   78.11%   -0.01%     
==========================================
  Files         325      325              
  Lines       21092    21097       +5     
==========================================
+ Hits        16477    16480       +3     
- Misses       3387     3388       +1     
- Partials     1228     1229       +1     
Impacted Files Coverage Δ
identity/manager.go 80.64% <100.00%> (+0.81%) ⬆️

... and 1 file with indirect coverage changes

@aeneasr aeneasr merged commit 78e31cb into master Jun 13, 2023
27 of 28 checks passed
@aeneasr aeneasr deleted the fix-identity-id-event branch June 13, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant