Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing id for login event #3315

Merged
merged 1 commit into from
Jun 14, 2023
Merged

fix: missing id for login event #3315

merged 1 commit into from
Jun 14, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 14, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner June 14, 2023 09:37
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #3315 (aebb6b6) into master (78e31cb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head aebb6b6 differs from pull request most recent head a5db6e7. Consider uploading reports for the commit a5db6e7 to get more accurate results

@@            Coverage Diff             @@
##           master    #3315      +/-   ##
==========================================
+ Coverage   78.07%   78.10%   +0.02%     
==========================================
  Files         325      325              
  Lines       21097    21102       +5     
==========================================
+ Hits        16472    16481       +9     
+ Misses       3393     3391       -2     
+ Partials     1232     1230       -2     
Impacted Files Coverage Δ
selfservice/flow/login/hook.go 85.60% <100.00%> (+0.56%) ⬆️

... and 1 file with indirect coverage changes

@aeneasr aeneasr merged commit b6b80a3 into master Jun 14, 2023
21 checks passed
@aeneasr aeneasr deleted the fix-session-id-next branch June 14, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants