Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename prompt=login to something that fits better #477

Closed
aeneasr opened this issue Jun 5, 2020 · 0 comments · Fixed by #478
Closed

Rename prompt=login to something that fits better #477

aeneasr opened this issue Jun 5, 2020 · 0 comments · Fixed by #478
Assignees
@aeneasr
Milestone
v0.4.0-alpha.1

Comments

@aeneasr
Copy link
Member

aeneasr commented Jun 5, 2020

Describe the bug

It should probably be reauth or something similar.
@aeneasr aeneasr added this to the v0.4.0-alpha.1 milestone Jun 5, 2020
@aeneasr aeneasr self-assigned this Jun 5, 2020
aeneasr added a commit that referenced this issue Jun 5, 2020
@aeneasr
refactor: rename prompt=login to refresh=true
93f01fc 
Closes #477

BREAKING CHANGE: To refresh a login session it is now required to append `refresh=true` instead of `prompt=login` as the second has implications for revoking an existing issue and might be confusing when used in combination with OpenID Connect.
@aeneasr aeneasr mentioned this issue Jun 5, 2020
Merged
5 tasks
aeneasr added a commit that referenced this issue Jun 5, 2020
@aeneasr
refactor: rename prompt=login to refresh=true (#478)
c04346e 
Closes #477

BREAKING CHANGE: To refresh a login session it is now required to append `refresh=true` instead of `prompt=login` as the second has implications for revoking an existing issue and might be confusing when used in combination with OpenID Connect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
None yet
Projects
None yet
Milestone
v0.4.0-alpha.1
Development

Successfully merging a pull request may close this issue.

refactor: rename prompt=login to refresh=true ory/kratos
1 participant
@aeneasr