Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how oidc providers normalize data #49

Closed
aeneasr opened this issue Jul 25, 2019 · 1 comment · Fixed by #393
Closed

Document how oidc providers normalize data #49

aeneasr opened this issue Jul 25, 2019 · 1 comment · Fixed by #393
Assignees
@aeneasr
Labels
package/selfservice/oidc Affects the OpenID Connect Self Service Strategy
Milestone
v0.3.0-alpha.1

Comments

@aeneasr
Copy link
Member

aeneasr commented Jul 25, 2019

We're normalizing data from OIDC providers to fit the general OpenID Connect Claim model. This is normally working as expected for OIDC certified providers, but non-oidc certified providers like GitHub need some more magic. Any type of enrichment (e.g. "how many repos does the user have?" should be done via an RPC).

We should document what the results of these providers look like. We also need to address that some providers only share a subset of resources, e.g.:

  • GitHub does not provider family name, first name, etc, nor address and so on
@aeneasr aeneasr added package/selfservice/oidc Affects the OpenID Connect Self Service Strategy module:docs labels Jul 25, 2019
@aeneasr aeneasr added this to the v0.0.2 milestone Jul 25, 2019
@aeneasr aeneasr self-assigned this Jul 25, 2019
@aeneasr aeneasr modified the milestones: v0.0.2, v0.0.1 Nov 4, 2019
@aeneasr aeneasr modified the milestones: v0.2.0-alpha.1, v0.2.1-alpha.1 May 2, 2020
@aeneasr aeneasr mentioned this issue May 4, 2020
Merged
@aeneasr
Copy link
Member Author

aeneasr commented May 5, 2020

Solve #380 first

aeneasr added a commit that referenced this issue May 6, 2020
@aeneasr
docs: improve social sign in guide
31d4e0f 
This patch changes the social sign in guide to represent more use cases such as Google and Facebook. Additionally, the example has been updated to work with Jsonnet.

This patch also documents limitations around merging user data from GitHub.

Closes #49
@aeneasr aeneasr mentioned this issue May 6, 2020
Merged
aeneasr added a commit that referenced this issue May 6, 2020
@aeneasr
docs: improve social sign in guide (#393)
647ced3 
This patch changes the social sign in guide to represent more use cases such as Google and Facebook. Additionally, the example has been updated to work with Jsonnet.

This patch also documents limitations around merging user data from GitHub.

Closes #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
package/selfservice/oidc Affects the OpenID Connect Self Service Strategy
Projects
None yet
Milestone
v0.3.0-alpha.1
Development

Successfully merging a pull request may close this issue.

docs: improve social sign in guide ory/kratos
1 participant
@aeneasr