Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hermes: Notification architecture #99

Closed
aeneasr opened this issue Nov 3, 2019 · 0 comments · Fixed by #146
Closed

hermes: Notification architecture #99

aeneasr opened this issue Nov 3, 2019 · 0 comments · Fixed by #146
Assignees
@aeneasr
Milestone
v0.1.0-alpha.1

Comments

@aeneasr
Copy link
Member

aeneasr commented Nov 3, 2019 •
edited
Loading

Several system components require the ability to notify a identity about something:

  • Account activation / verification must send out an email or SMS containing a code for activating the account.
  • Account recovery must send out an email with a password reset link
  • Sending out a welcome email
  • ...

To support this we need a system capable of delivering notifications using several protocols:

  • SMTP
  • SMS (Maybe Twillio or something similar?)

As well as being able to render the notification message itself with localization.

One possibility to solve templating would be to provide default (english) templates for all protocols and workflows and leave open the possibility to "mount" a directory (think Kubernetes) to load localized and customized templates:

+ default
  + email
    + account_recovery.html.tmpl (for html templates)
    + account_recovery.tmpl
    + ...
  + sms
    + account_recovery.tmpl
    + ...

plus a config variable such as hermes.templates pointing at a directory with a structure such as:

+ default
  + email
    + account_recovery.html.tmpl (for html templates)
    + account_recovery.tmpl
    + ...
  + sms
    + account_recovery.tmpl
    + ...
+ i18n
  + de_DE
    + email
      + ...
@aeneasr aeneasr added this to the v0.0.1 milestone Nov 3, 2019
@aeneasr aeneasr self-assigned this Nov 3, 2019
@aeneasr aeneasr changed the title hermes: Notificatino architecture hermes: Notification architecture Nov 4, 2019
aeneasr added a commit that referenced this issue Dec 10, 2019
@aeneasr
unstaged
8f2f98b 
closes #99
aeneasr added a commit that referenced this issue Dec 10, 2019
@aeneasr
courier: Implement message templates and SMTP delivery
2ef097f 
This patch adds a message templates (with override capabilities)
and SMTP delivery.

Integration tests using MailHog test fault resilience and e2e email
delivery.

This system is designed to be extended for SMS and other use cases.

Closes #99
@aeneasr aeneasr mentioned this issue Dec 10, 2019
Merged
aeneasr added a commit that referenced this issue Dec 10, 2019
@aeneasr
courier: Implement message templates and SMTP delivery (#146)
dc674bf 
This patch adds a message templates (with override capabilities)
and SMTP delivery.

Integration tests using MailHog test fault resilience and e2e email
delivery.

This system is designed to be extended for SMS and other use cases.

Closes #99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
None yet
Projects
None yet
Milestone
v0.1.0-alpha.1
Development

Successfully merging a pull request may close this issue.

courier: Implement message templates and SMTP delivery ory/kratos
1 participant
@aeneasr