Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Team id in slack oidc #1409

Merged
merged 5 commits into from
Jun 14, 2021
Merged

Conversation

trobinpl
Copy link
Contributor

@trobinpl trobinpl commented Jun 10, 2021

I did name the property in the Claims struct Team, although I can see it being called something more generic like OrganizationId since Team may be a specific Slack term, but some generic organization seems like something that will be present in many other OAuth providers.

Closes #1408

Related issue

#1408

Proposed changes

Reasoning behind this change described in the related issue. Basically it's a small change to include the team ID user belongs to in the Slack OIDC provider response so it's usable information in the hooks

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@CLAassistant
Copy link

CLAassistant commented Jun 10, 2021

CLA assistant check
All committers have signed the CLA.

@trobinpl trobinpl changed the title Teamid in slack oidc feat: Teamid in slack oidc Jun 10, 2021
@trobinpl trobinpl changed the title feat: Teamid in slack oidc feat: Team id in slack oidc Jun 10, 2021
@aeneasr
Copy link
Member

aeneasr commented Jun 11, 2021

Thank you very much for your contribution to the documentation! Due to the way Docusaurus versioning works, you need to make the changes in two locations:

  • docs/versioned_docs/version-v{version}/path/to/file
  • docs/docs/path/to/file

Without making them in both locations, the changes will most likely be lost when releasing another version. Thank you! :)

@trobinpl
Copy link
Contributor Author

trobinpl commented Jun 12, 2021

@aeneasr I've included the same documentation change in both locations you've mentioned 👍

@aeneasr aeneasr merged commit e4d021a into ory:master Jun 14, 2021
@aeneasr
Copy link
Member

aeneasr commented Jun 14, 2021

Great, thank you!

@aeneasr
Copy link
Member

aeneasr commented Jun 14, 2021

Awesome, thank you! 🎉 Your contribution makes Ory better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include team ID in Slack OIDC response
3 participants