Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove CII best practices #1444

Closed
wants to merge 1 commit into from
Closed

chore: remove CII best practices #1444

wants to merge 1 commit into from

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Jun 17, 2021

The CII best practices actually only concern ory/hydra, so we should remove it from the Kratos README?
https://bestpractices.coreinfrastructure.org/projects/364

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #1444 (2ddf56e) into master (4ffd8eb) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
+ Coverage   73.18%   73.20%   +0.02%     
==========================================
  Files         229      229              
  Lines        9912     9912              
==========================================
+ Hits         7254     7256       +2     
+ Misses       2050     2049       -1     
+ Partials      608      607       -1     
Impacted Files Coverage Δ
persistence/sql/persister_courier.go 87.27% <0.00%> (+3.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ffd8eb...2ddf56e. Read the comment docs.

@aeneasr
Copy link
Member

aeneasr commented Jun 18, 2021

Let's rather go through CII for kratos and link that. Could you do that?

@vinckr
Copy link
Member Author

vinckr commented Jun 18, 2021

Makes sense yes! I'll close this then.

@vinckr vinckr closed this Jun 18, 2021
@vinckr vinckr mentioned this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants