feat: allow multiple webhook body sources #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Jul 29, 2021
| "file:///path/to/body.jsonnet", | ||
| "/path/to/body.jsonnet", | ||
| "./body.jsonnet", | ||
| "base64://ZnVuY3Rpb24oY3R4KSB7CiAgaWRlbnRpdHlfaWQ6IGlmIGN0eFsiaWRlbnRpdHkiXSAhPSBudWxsIHRoZW4gY3R4LmlkZW50aXR5LmlkLAp9=" |
There was a problem hiding this comment.
Do we allow loading from http too?
There was a problem hiding this comment.
Yes, if the loader is registered.
Codecov Report
@@ Coverage Diff @@
## master #1606 +/- ##
=======================================
Coverage 74.17% 74.18%
=======================================
Files 257 258 +1
Lines 12557 12568 +11
=======================================
+ Hits 9314 9323 +9
- Misses 2624 2626 +2
Partials 619 619
Continue to review full report at Codecov.
|
aeneasr
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Currently the webhook body can only be loaded from a local file. This allows to use any source enabled in the JSONSchema loaders (file, base64, https, ...)
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments