feat: hot-reload TLS certificates #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2744 +/- ##
==========================================
- Coverage 75.22% 75.16% -0.06%
==========================================
Files 294 294
Lines 17081 17082 +1
==========================================
- Hits 12849 12840 -9
- Misses 3253 3265 +12
+ Partials 979 977 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zepatrik
requested changes
Sep 28, 2022
| return p.getTSLCertificates( | ||
| type CertFunc = func(*tls.ClientHelloInfo) (*tls.Certificate, error) | ||
|
|
||
| func (p *Config) GetTLSCertificatesForPublic(ctx context.Context) CertFunc { |
There was a problem hiding this comment.
It took me a few seconds to spot the typo 😂 nice find
aeneasr
requested changes
Oct 4, 2022
alnr
force-pushed
the
feat/tls-autoreload
branch
from
f87b62d
to
ee8f300
Compare
zepatrik
approved these changes
Oct 4, 2022
aeneasr
reviewed
Oct 4, 2022
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ory/hydra#2850 but for Kratos