Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing usage to recovery_code_invalid template #2798

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

jonas-jonas
Copy link
Member

This PR fixes the usage of the wrong template when trying to recover a not registered account. Also clarifies the tests to reflect this case.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #2798 (d641b5e) into master (84ea0cf) will increase coverage by 0.01%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master    #2798      +/-   ##
==========================================
+ Coverage   75.84%   75.86%   +0.01%     
==========================================
  Files         302      302              
  Lines       17796    17806      +10     
==========================================
+ Hits        13498    13508      +10     
+ Misses       3264     3261       -3     
- Partials     1034     1037       +3     
Impacted Files Coverage Δ
selfservice/strategy/code/sender.go 80.76% <0.00%> (ø)
courier/email_templates.go 68.42% <60.00%> (+2.46%) ⬆️
session/test/persistence.go 98.73% <0.00%> (-1.27%) ⬇️
courier/template/email/recovery_code_invalid.go 100.00% <0.00%> (+40.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonas-jonas
Copy link
Member Author

jonas-jonas commented Oct 13, 2022

failing CI is test coverage & flaky tests in cypress... Maybe we can turn the flaky test failure off?

@aeneasr
Copy link
Member

aeneasr commented Oct 13, 2022

Or fix the flakes at some point ;)

@aeneasr aeneasr merged commit 5ac7553 into master Oct 13, 2022
@aeneasr aeneasr deleted the fix/templateIssues branch October 13, 2022 12:29
mmeller-wikia pushed a commit to Wikia/kratos that referenced this pull request Oct 21, 2022
mmeller-wikia pushed a commit to Wikia/kratos that referenced this pull request Oct 21, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants