Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send out correct verification invalid email in code strategy #2908

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

jonas-jonas
Copy link
Member

Fixes wrong email templates used when sending the "invalid" verification via code email and adds some tests to detect these issues in the future.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #2908 (5b16e46) into master (e1119e8) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #2908   +/-   ##
=======================================
  Coverage   76.12%   76.12%           
=======================================
  Files         308      308           
  Lines       18887    18887           
=======================================
  Hits        14378    14378           
  Misses       3390     3390           
  Partials     1119     1119           
Impacted Files Coverage Δ
selfservice/strategy/code/code_sender.go 78.07% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit d2bb67a into master Nov 23, 2022
@aeneasr aeneasr deleted the fix/verificationCodeInvalidEmail branch November 23, 2022 07:32
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants