Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require verification on login #2927

Merged
merged 1 commit into from
Dec 6, 2022
Merged

feat: require verification on login #2927

merged 1 commit into from
Dec 6, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 5, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr self-assigned this Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #2927 (9078421) into master (59c30b6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2927      +/-   ##
==========================================
- Coverage   76.20%   76.17%   -0.04%     
==========================================
  Files         308      308              
  Lines       18943    18943              
==========================================
- Hits        14435    14429       -6     
- Misses       3391     3394       +3     
- Partials     1117     1120       +3     
Impacted Files Coverage Δ
persistence/sql/persister_courier.go 82.82% <0.00%> (-4.05%) ⬇️
persistence/sql/persister.go 72.86% <0.00%> (-1.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit efb8ae8 into master Dec 6, 2022
@aeneasr aeneasr deleted the allow-hooks-global branch December 6, 2022 08:04
CNLHC pushed a commit to seekthought/kratos that referenced this pull request May 16, 2023
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant