Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quickstart demos #2940

Merged
merged 3 commits into from
Jan 4, 2023
Merged

fix: quickstart demos #2940

merged 3 commits into from
Jan 4, 2023

Conversation

SkypLabs
Copy link
Contributor

@SkypLabs SkypLabs commented Dec 7, 2022

Hi there,

I started to play with your quickstart examples and I realised that the Kratos configuration files are targeting very old versions of the tool (e.g. v0.7.1-alpha.1), which make them invalid according to your current configuration JSON schema.

This PR upgrades the version numbers in the Kratos configuration files located in contrib/quickstart. I also took the liberty to upgrade the Docker image of Oathkeeper in quickstart-oathkeeper.yml.

Related issue(s)

N/A

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Some of the checklist items are irrelevant for this PR.

Further Comments

None.

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2022

CLA assistant check
All committers have signed the CLA.

@SkypLabs SkypLabs changed the title fix: upgrade service versions in quickstart demos fix: upgrade Kratos version in quickstart demos Dec 7, 2022
@SkypLabs
Copy link
Contributor Author

SkypLabs commented Dec 7, 2022

The Oathkeeper quickstart demo is partially broken as the /sessions path is not part of access rules despite the presence of a link to the "Session Information" page on the Dashboard:

Screenshot 2022-12-07 at 17-23-45 Session Information

Would you like me to fix it in this PR as well? If so, I could rename it to "fix: quickstart demos" or similar.

aeneasr
aeneasr previously approved these changes Dec 17, 2022
@aeneasr
Copy link
Member

aeneasr commented Dec 17, 2022

Would you like me to fix it in this PR as well? If so, I could rename it to "fix: quickstart demos" or similar.

That would be awesome! :)

@SkypLabs SkypLabs changed the title fix: upgrade Kratos version in quickstart demos fix: quickstart demos Jan 3, 2023
@SkypLabs
Copy link
Contributor Author

SkypLabs commented Jan 3, 2023

The Oathkeeper quickstart demo is partially broken as the /sessions path is not part of access rules despite the presence of a link to the "Session Information" page on the Dashboard

I removed the unused routes (/debug and /dashboard) and added the missing ones (/sessions, /health/alive and /health/ready).

I also rebased my branch onto master.

@aeneasr
Copy link
Member

aeneasr commented Jan 4, 2023

Thank you very much!

@aeneasr aeneasr merged commit a7720b2 into ory:master Jan 4, 2023
@SkypLabs SkypLabs deleted the bugfix/contrib-versions branch January 16, 2023 16:30
CNLHC pushed a commit to seekthought/kratos that referenced this pull request May 16, 2023
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants