Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup test #2964

Merged
merged 1 commit into from
Dec 17, 2022
Merged

chore: cleanup test #2964

merged 1 commit into from
Dec 17, 2022

Conversation

CaptainStandby
Copy link
Contributor

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #2964 (d0f1094) into master (b407aa9) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
- Coverage   76.16%   76.14%   -0.03%     
==========================================
  Files         309      309              
  Lines       19046    19046              
==========================================
- Hits        14507    14503       -4     
- Misses       3414     3417       +3     
- Partials     1125     1126       +1     
Impacted Files Coverage Δ
session/test/persistence.go 99.06% <0.00%> (-0.94%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 561e568 into master Dec 17, 2022
@aeneasr aeneasr deleted the hf-fix-build-v2 branch December 17, 2022 08:37
@CaptainStandby CaptainStandby restored the hf-fix-build-v2 branch December 17, 2022 08:48
@CaptainStandby CaptainStandby mentioned this pull request Dec 17, 2022
7 tasks
@CaptainStandby
Copy link
Contributor Author

@aeneasr I missed one thing last night --> #2965

peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants