-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove duplicate queries from whoami calls #2995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f6ef33
to
887a084
Compare
887a084
to
7a229aa
Compare
79309dc
to
f021cab
Compare
kelkarajay
suggested changes
Jan 3, 2023
kelkarajay
reviewed
Jan 3, 2023
540781c
to
5ae2be3
Compare
5ae2be3
to
f99cac9
Compare
f99cac9
to
73f8313
Compare
9411175
to
14fbf1c
Compare
14fbf1c
to
4c6de1a
Compare
7bfcc83
to
c696602
Compare
b6c2c1b
to
7c1ba22
Compare
Codecov Report
@@ Coverage Diff @@
## master #2995 +/- ##
==========================================
+ Coverage 76.18% 76.49% +0.31%
==========================================
Files 309 308 -1
Lines 19085 19177 +92
==========================================
+ Hits 14539 14669 +130
+ Misses 3422 3404 -18
+ Partials 1124 1104 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
LGTM |
CNLHC
pushed a commit
to seekthought/kratos
that referenced
this pull request
May 16, 2023
Introduces an expand API to the identity persister which greatly improves whoami performance. Closes ory#2402
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
Introduces an expand API to the identity persister which greatly improves whoami performance. Closes ory#2402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2402
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments