Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't return 500 if active strategy is disabled #3197

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

jonas-jonas
Copy link
Member

Fixes https://github.com/ory-corp/cloud/issues/4297

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #3197 (27ae94a) into master (08a3447) will increase coverage by 0.03%.
The diff coverage is 63.63%.

❗ Current head 27ae94a differs from pull request most recent head c585218. Consider uploading reports for the commit c585218 to get more accurate results

@@            Coverage Diff             @@
##           master    #3197      +/-   ##
==========================================
+ Coverage   77.68%   77.72%   +0.03%     
==========================================
  Files         319      319              
  Lines       20162    20171       +9     
==========================================
+ Hits        15663    15678      +15     
+ Misses       3301     3295       -6     
  Partials     1198     1198              
Impacted Files Coverage Δ
selfservice/flow/recovery/strategy.go 100.00% <ø> (+25.00%) ⬆️
selfservice/flow/recovery/handler.go 58.73% <20.00%> (-2.94%) ⬇️
driver/registry_default_recovery.go 100.00% <100.00%> (ø)
driver/registry_default_verification.go 92.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 3a734c2 into master Mar 30, 2023
@aeneasr aeneasr deleted the jonas-jonas/no500onDisabledActiveStrategy branch March 30, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants