Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow marking OIDC provider-verified addresses as verified during registration #3448

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Aug 22, 2023

See #3445

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #3448 (464f369) into master (610c76d) will decrease coverage by 0.01%.
Report is 8 commits behind head on master.
The diff coverage is 56.57%.

❗ Current head 464f369 differs from pull request most recent head 3a9535c. Consider uploading reports for the commit 3a9535c to get more accurate results

@@            Coverage Diff             @@
##           master    #3448      +/-   ##
==========================================
- Coverage   77.99%   77.98%   -0.01%     
==========================================
  Files         327      326       -1     
  Lines       21591    21588       -3     
==========================================
- Hits        16839    16835       -4     
+ Misses       3496     3494       -2     
- Partials     1256     1259       +3     
Files Changed Coverage Δ
selfservice/flow/flow.go 100.00% <ø> (ø)
selfservice/strategy/code/strategy_recovery.go 70.56% <0.00%> (ø)
selfservice/strategy/link/strategy_recovery.go 63.33% <0.00%> (ø)
selfservice/flow/verification/handler.go 55.14% <10.00%> (ø)
selfservice/strategy/oidc/strategy_registration.go 67.00% <59.37%> (+0.33%) ⬆️
selfservice/hook/verification.go 76.74% <62.50%> (ø)
driver/registry_default.go 87.02% <71.42%> (ø)
request/builder.go 72.72% <75.00%> (ø)
courier/http.go 55.55% <100.00%> (ø)
courier/sms.go 60.37% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

@aeneasr aeneasr merged commit e7b33a1 into master Aug 22, 2023
26 checks passed
@aeneasr aeneasr deleted the feat/oidc-preverified-addresses branch August 22, 2023 14:30
splaunov pushed a commit to monta-app/kratos that referenced this pull request Apr 23, 2024
…ng registration (ory#3448)

This feature allows marking emails provided by social sign in providers as verified.

Closes ory#3445
Closes ory#3424
Closes ory#1057

Co-authored-by: Krzysztof Bogacki <krzysztof.bogacki@leancode.pl>

(cherry picked from commit e7b33a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants