Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add event #3524

Merged
merged 1 commit into from
Sep 20, 2023
Merged

feat: add event #3524

merged 1 commit into from
Sep 20, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Sep 20, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #3524 (1e1c635) into master (4c34c24) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 1e1c635 differs from pull request most recent head ab71465. Consider uploading reports for the commit ab71465 to get more accurate results

@@            Coverage Diff             @@
##           master    #3524      +/-   ##
==========================================
+ Coverage   78.34%   78.36%   +0.01%     
==========================================
  Files         341      341              
  Lines       22691    22701      +10     
==========================================
+ Hits        17777    17789      +12     
+ Misses       3586     3585       -1     
+ Partials     1328     1327       -1     
Files Changed Coverage Δ
session/manager_http.go 79.47% <100.00%> (+0.10%) ⬆️
x/events/events.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@aeneasr aeneasr merged commit 75031e6 into master Sep 20, 2023
30 checks passed
@aeneasr aeneasr deleted the session-checked branch September 20, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants