feat: add twitter SSO

[aeneasr]

Closes #517 #2117

ory/docs#1658

[codecov]

Codecov Report

Attention: Patch coverage is 42.93785% with 101 lines in your changes are missing coverage. Please review.

Project coverage is 78.13%. Comparing base (7f8a7f1) to head (d2d63ff).
Report is 1 commits behind head on master.

Files	Patch %	Lines
selfservice/strategy/oidc/provider_x.go	0.00%	65 Missing ⚠️
selfservice/strategy/oidc/strategy.go	55.55%	24 Missing and 8 partials ⚠️
selfservice/strategy/oidc/strategy_settings.go	62.50%	1 Missing and 2 partials ⚠️
selfservice/strategy/oidc/provider_dingtalk.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3778      +/-   ##
==========================================
- Coverage   78.37%   78.13%   -0.24%     
==========================================
  Files         348      349       +1     
  Lines       24011    24113     +102     
==========================================
+ Hits        18818    18841      +23     
- Misses       3772     3852      +80     
+ Partials     1421     1420       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zepatrik]

Looks good, just some minor questions.

[zepatrik]

To implement "Login with X", use the gologin packages which provide login handlers for OAuth1 and OAuth2 providers.

To call the Twitter, Digits, or Tumblr OAuth1 APIs, use the higher level Go API clients.

Did you check that note in the repo's readme?

[zepatrik]

The usage later looks valid IMO.

[aeneasr]

I think this should be fine!

[zepatrik]

What exactly is the cheat referred to here? Do we need to set a code, but it gets ignored by twitter? Will it still be in the URL when being redirected back?

[aeneasr]

Good question - I took over some of the code from PR #517 where this originally was at. I believe that OAuth1 doesn't return a code parameter like OAuth2, and that would break the provider logic. So the added this workaround? I'm not sure to be honest.