feat: log claims #3798
Merged
feat: log claims #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aeneasr
previously approved these changes
Mar 5, 2024
zepatrik
previously approved these changes
Mar 5, 2024
|
CI fails |
hperl
force-pushed
the
hperl/claims-event
branch
from
b6e0bc5
to
a8e3475
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3798 +/- ##
=======================================
Coverage 78.14% 78.14%
=======================================
Files 349 349
Lines 24118 24121 +3
=======================================
+ Hits 18846 18849 +3
Misses 3852 3852
Partials 1420 1420 ☔ View full report in Codecov by Sentry. |
aeneasr
reviewed
Mar 6, 2024
| s.forwardError(w, r, req, s.handleError(w, r, req, pid, nil, err)) | ||
| return | ||
| } | ||
|
|
||
| span.SetAttributes(attribute.StringSlice("claims", maps.Keys(claims.RawClaims))) |
There was a problem hiding this comment.
Wouldn't this leak PII into the tracing system?
There was a problem hiding this comment.
No, this is just the keys, meaning the claim keys. The PII is just in the values, which we don't send.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there are issues with mapping the claims from a SSO provider to an identity trait. This change adds the claims that we get back to the event, so that we can better debug these issues.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments