fix: drop trigram index on identifiers #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Mar 19, 2024
...istence/sql/migrations/sql/20240318143139000000_drop_identity_search_index.postgres.down.sql
Show resolved
Hide resolved
aeneasr
requested changes
Mar 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3827 +/- ##
==========================================
+ Coverage 77.95% 77.98% +0.02%
==========================================
Files 358 358
Lines 25165 25160 -5
==========================================
+ Hits 19617 19620 +3
+ Misses 4041 4033 -8
Partials 1507 1507 ☔ View full report in Codecov by Sentry. |
aeneasr
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trigram GIN index takes up a significant amount of database storage. Fuzzy search should instead be build using a dedicated external service. This will allow indexing other traits as well, based on needs.