Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: passing transient payloads #3838

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Mar 22, 2024

This fixes some bugs where we didn't yet copy around the transient data hard enough.

Related issue(s)

https://github.com/ory-corp/cloud/issues/6067

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl self-assigned this Mar 22, 2024
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I suspected I missed a few places. Unified state machine when? 😅

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (8f8fd90) to head (ac62bfd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3838      +/-   ##
==========================================
+ Coverage   77.98%   78.01%   +0.03%     
==========================================
  Files         359      359              
  Lines       25187    25190       +3     
==========================================
+ Hits        19641    19652      +11     
+ Misses       4039     4032       -7     
+ Partials     1507     1506       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit d01b670 into master Mar 22, 2024
32 checks passed
@aeneasr aeneasr deleted the hperl/fix-transient-payloads branch March 22, 2024 15:36
panbanda pushed a commit to panbanda/kratos that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants