Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: execute verification & verification_ui properly in login flows #3847

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Mar 25, 2024
@jonas-jonas jonas-jonas changed the title fix: check in verification hook fix: execute verification & verification_ui properly in login flows Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 77.96%. Comparing base (04f0231) to head (b3cd114).
Report is 2 commits behind head on master.

Files Patch % Lines
selfservice/flow/login/hook.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3847      +/-   ##
==========================================
- Coverage   77.96%   77.96%   -0.01%     
==========================================
  Files         359      359              
  Lines       25192    25203      +11     
==========================================
+ Hits        19642    19650       +8     
- Misses       4042     4043       +1     
- Partials     1508     1510       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas marked this pull request as ready for review March 26, 2024 09:48
@aeneasr aeneasr merged commit 5aad1c1 into master Mar 26, 2024
31 checks passed
@aeneasr aeneasr deleted the jonas-jonas/fixVerificationHook branch March 26, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants