Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing env vars to set up guide #3855

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix: add missing env vars to set up guide #3855

merged 1 commit into from
Mar 26, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Mar 26, 2024

Closes #3828

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr mentioned this pull request Mar 26, 2024
5 tasks
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.96%. Comparing base (ad0619d) to head (3c82467).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3855      +/-   ##
==========================================
- Coverage   78.01%   77.96%   -0.05%     
==========================================
  Files         359      359              
  Lines       25203    25203              
==========================================
- Hits        19662    19650      -12     
- Misses       4034     4044      +10     
- Partials     1507     1509       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@thedjpetersen thedjpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and confirmed as working

@thedjpetersen
Copy link

Might be worth just updating the getting started guide as well

@aeneasr aeneasr merged commit da90502 into master Mar 26, 2024
30 of 31 checks passed
@aeneasr aeneasr deleted the update-secrets branch March 26, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quickstart docker not working
2 participants