Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't require connection_uri in SMTP #3861

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Apr 4, 2024

Related issue(s)

(Actually) Closes #3559 and closes #3693

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.02%. Comparing base (2cdfc70) to head (7f4dc72).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3861      +/-   ##
==========================================
- Coverage   78.04%   78.02%   -0.03%     
==========================================
  Files         360      360              
  Lines       25233    25203      -30     
==========================================
- Hits        19694    19665      -29     
- Misses       4033     4034       +1     
+ Partials     1506     1504       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 800f8f1 into master Apr 4, 2024
30 of 32 checks passed
@aeneasr aeneasr deleted the jonas-jonas/dontRequireConnectionURI branch April 4, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send Email via HTTP and not SMTP to Sendgrid SMTP Connection URI is required on HTTP delivery strategy
3 participants